fix: add workaround to fix fetching state from checkpointz#6874
Merged
wemeetagain merged 1 commit intounstablefrom Jun 10, 2024
Merged
fix: add workaround to fix fetching state from checkpointz#6874wemeetagain merged 1 commit intounstablefrom
wemeetagain merged 1 commit intounstablefrom
Conversation
nflaig
commented
Jun 10, 2024
| ...init, | ||
| method: definition.method, | ||
| headers: mergeHeaders(headers, req.headers), | ||
| headers: mergeHeaders(headers, req.headers, init.headers), |
Member
Author
There was a problem hiding this comment.
This is anyways better imo, we should allow the user to override any header manually via request init
11 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #6874 +/- ##
============================================
- Coverage 62.75% 62.75% -0.01%
============================================
Files 578 578
Lines 61264 61278 +14
Branches 2114 2112 -2
============================================
+ Hits 38449 38457 +8
- Misses 22776 22783 +7
+ Partials 39 38 -1 |
wemeetagain
approved these changes
Jun 10, 2024
Contributor
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
Member
|
🎉 This PR is included in v1.20.0 🎉 |
nflaig
added a commit
that referenced
this pull request
Apr 28, 2025
**Motivation** Part of #7682, we can safely remove these workarounds in our next release as we can be sure all dependent software has been updated after Pectra hard fork on mainnet. **Description** - Remove workaround for go-eth2-client, reverts #6953 - Remove workaround fetching state from checkpointz, partially reverts #6874
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adds temporary workaround to fix fetching state from Checkpointz.
Description
mergeHeadersto support multiple headers as argsEth-consensus-versionheader as required by the spec, see Eth-Consensus-Version header is missing in getStateV2 response ethpandaops/checkpointz#164